Skip to content

Enhancement: Enable Dynamic 'closeHref' Variable for PM Block Redirection#5057

Merged
ryancooley merged 1 commit into
developfrom
task/FOUR-9450
Jul 28, 2023
Merged

Enhancement: Enable Dynamic 'closeHref' Variable for PM Block Redirection#5057
ryancooley merged 1 commit into
developfrom
task/FOUR-9450

Conversation

@sanjacornelius
Copy link
Copy Markdown
Contributor

@sanjacornelius sanjacornelius commented Jul 28, 2023

FOUR-9450

This PR addresses an issue where, when editing a PM Block in the modeler and selecting the 'CLOSE' link, the user is erroneously redirected to the Process Listing page instead of the expected PM Block listing page. The update ensures that the 'closeHref' variable is made dynamic, enabling a seamless redirection experience for users, directing them to the appropriate PM Block listing page upon clicking the 'CLOSE' link.

How to Test

Test 'CLOSE' link functionality in the modeler:

  1. Edit a PM Block.
  2. In modeler click the 'CLOSE' link.
  3. Verify that the user is redirected to the PM Block listing page.
  4. Ensure the URL matches the expected PM Block listing page address.

Test 'closeHref' variable behavior with Processes:

  1. Edit a Process.
  2. In modeler click the 'CLOSE' link.
  3. Verify that the user is redirected to the Process listing page.
  4. Ensure the URL matches the expected Process listing page address.

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@eiresendez eiresendez self-requested a review July 28, 2023 19:06
Copy link
Copy Markdown
Contributor

@eiresendez eiresendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close redirect is done correctly 👍

@ryancooley ryancooley merged commit 88d9f82 into develop Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants